version, metrics: allow to build on non-unix platforms #16679
Conversation
c8de18b to
b58cbf7
Compare
b58cbf7 to
7fd6c22
Compare
|
test-me-please |
7fd6c22 to
d3f6f44
Compare
|
Rebased to pick up updated kind version to fix conformance test GH action failures. |
|
test-me-please |
d3f6f44 to
e0f4d36
Compare
|
Rebased to pick up more conformance test fixes from |
|
test-me-please |
|
test-gke failed on #16659 (https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/5910/testReport/) |
There was a problem hiding this comment.
Thanks for doing this, Tobias!
I found that it's hard to prevent these sort of changes from breaking (had to fix some macOS builds a few times). Did you think of adding some kind of check that runs builds for different OSes, even if it's just a subset of packages for now?
Yeah, that's a good point. Though it will probably a bit of a challenge to determine the correct subset of packages we want to build on other platforms and I imagine it to change over time as well. For now I'd go with anything imported by cilium/cilium-cli as well as any package in cilium/cilium which have |
Sounds good!
Personally, I think everything should be buildable, and it's ought to be possible to run pure unit tests, but that's not something we will be can realistically achieve very soon... How about the operator, I was able to work on it natively on macOS in the past, and in theory it should remain free of Linux-isms, right? |
e0f4d36 to
8e31906
Compare
Created #16843 to track which packages we want to be able to build on non-Linux platforms. |
8e31906 to
6606842
Compare
|
Rebased to pick up CI 3.0 fixes. |
6606842 to
69f62d2
Compare
|
test-me-please |
|
test-gke timed out waiting for CI images: https://jenkins.cilium.io/job/Cilium-PR-K8s-GKE/6006 |
This package is a transitive dependency in cilium-cli, but currently it fails to build on non-unix platforms (e.g. windows) due to its use of golang.org/x/sys/unix. However, we want still to be able to build it for some these platforms, see e.g. cilium/cilium-cli#231. Fix the build by moving all unix-specific functionality (i.e. the Uname call) to a separate file, protected by build tags. Signed-off-by: Tobias Klauser <tobias@cilium.io>
This package is a transitive dependency in cilium-cli, but currently it fails to build on non-unix platforms (e.g. windows) due to its use of golang.org/x/sys/unix. However, we want still to be able to build it for some these platforms, see e.g. cilium/cilium-cli#231. Fix the build by moving all unix-specific functionality (i.e. the use of unix.Errno) to a separate file, protected by build tags. Signed-off-by: Tobias Klauser <tobias@cilium.io>
69f62d2 to
230e619
Compare
|
test-me-please |
These packages are transitive dependencies in cilium-cli, but currently they
fails to build on non-unix platforms (e.g. windows) due to their use of
golang.org/x/sys/unix.
However, we want still to be able to build it for some these platforms,
see e.g. cilium/cilium-cli#231. Fix the build
by moving all unix-specific functionality (i.e. the Uname call) to
separate files, protected by build tags.
Also marking for backports to 1.10 since we vendor a stable cilium/cilium release into cilium-cli (currently v1.9.8, but switching to v1.10 with cilium/cilium-cli#358 once all necessary fixes have been backported).