Skip to content

docs: Fix command for overwriting iptables on kube-proxy replacement install #16264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

docs: Fix command for overwriting iptables on kube-proxy replacement install #16264

merged 1 commit into from
Sep 15, 2021

Conversation

Stijn98s
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Updated the restore iptables command because this command wasn't working on Ubuntu 20.10 arm64.

@Stijn98s Stijn98s requested a review from a team as a code owner May 21, 2021 14:26
@Stijn98s Stijn98s requested a review from a team May 21, 2021 14:26
@maintainer-s-little-helper
Copy link

Commit a55db194ecfb21110c14dd104fe896cee6b25f41 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@Stijn98s Stijn98s requested a review from qmonnet May 21, 2021 14:26
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 21, 2021
@qmonnet qmonnet added needs-backport/1.8 area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. labels May 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 21, 2021
@qmonnet qmonnet added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. release-note/misc This PR makes changes that have no direct user impact. labels May 21, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 21, 2021
@qmonnet qmonnet removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 21, 2021
qmonnet
qmonnet reviewed May 21, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The change looks good, but I would be curious to understand why the previous command wouldn't work. What error did you get?

@Stijn98s
Copy link
Contributor Author

Stijn98s commented May 21, 2021 •
edited
Loading

Didn't get a clear error. The changes didn't got applied. These errors occured.

Can't open /dev/fd/63: No such file or directory
and
Warning: iptables-legacy tables present, use iptables-legacy-save to see them

But with this command the changes got applied.

@Stijn98s Stijn98s requested a review from qmonnet May 21, 2021 14:49
@qmonnet qmonnet changed the title Fix overwriting iptables for kube-proxy free installation docs: Fix command for overwriting iptables on kube-proxy replacement install May 21, 2021
qmonnet
qmonnet approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, did you run the command with sudo? Process substitution might be at play here.

If so, let's update the command indeed to avoid other people to hit the same issue.

@Stijn98s
Copy link
Contributor Author

Yea, added sudo to both commands. Still didn't work

@qmonnet
Copy link
Member

qmonnet commented May 21, 2021

Yes, I suppose this is because of the sudo that the <(...) syntax didn't work. See the answers I linked if you want the details. All good for me!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 21, 2021
aanm
aanm reviewed May 21, 2021
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qmonnet but wouldn't we need something like sudo iptables-save | grep -v KUBE | sudo iptables-restore? at the very least: sudo su -c "iptables-save | grep -v KUBE | iptables-restore"?

@qmonnet
Copy link
Member

qmonnet commented May 21, 2021

True, we can also add the sudo everywhere. This would require updating the other iptables-save commands in the document, though.

(At least with the new form in this commit, a missing sudo will fail with Fatal: can't open lock file /run/xtables.lock: Permission denied, which is a better indication than what we had previously.)

@qmonnet qmonnet removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 21, 2021
@stale stale bot removed the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Jul 16, 2021
@aanm
Copy link
Member

aanm commented Jul 16, 2021

@Stijn98s can you rebase the PR? 🙏

@stale
Copy link

stale bot commented Aug 21, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale. label Aug 21, 2021
@Stijn98s @aanm
Fix overwriting iptables for kube-proxy free installation
f5f827b 
Signed-off-by: Stijn Smits <stijn@stijn98s.nl>
@aanm aanm merged commit 27fd5cc into cilium:master Sep 15, 2021
This was referenced Sep 27, 2021
Closed
Closed
@jibi jibi mentioned this pull request Sep 29, 2021
Merged
@glibsm glibsm mentioned this pull request Oct 4, 2021
Merged
@glibsm glibsm mentioned this pull request Oct 4, 2021
Merged
@joestringer joestringer mentioned this pull request Oct 13, 2021
Merged
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. release-note/misc This PR makes changes that have no direct user impact. stale The stale bot thinks this issue is old. Add "pinned" label to prevent this from becoming stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Stijn98s @qmonnet @pchaigno @brb @aanm @jibi @glibsm @errordeveloper