examples, connectivity-check, test: Use even-numbered nodePort #16158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the same logic as cilium#15988, we want to use an even-numbered port to reduce the likelihood that the underlying kernel allocates a conflicting port for the nodePort. Fixes: cilium#13071 Signed-off-by: Chris Tarazi <chris@isovalent.com>
630452b to
bb90110
Compare
pchaigno
approved these changes
May 14, 2021
|
test-me-please Edit: 1.21-4.9 hit #15097, ConformanceAKS hit #16112 |
nebril
approved these changes
May 19, 2021
joestringer
approved these changes
May 19, 2021
|
Failures are unrelated, @christarazi could you triage / link the relevant flakes? Then we can merge this. |
|
@joestringer I linked the flakes: #16158 (comment) |
This was referenced May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the same logic as #15988,
we want to use an even-numbered port to reduce the likelihood that the
underlying kernel allocates a conflicting port for the nodePort.
Fixes: #13071
Signed-off-by: Chris Tarazi chris@isovalent.com