Skip to content

Conversation

nebril
Copy link
Member

@nebril nebril commented Apr 16, 2021

This change makes K8s ginkgo test suite download kubectl version
compatible with current cluster version if it's not available.

@nebril nebril requested a review from a team as a code owner April 16, 2021 19:04
@nebril nebril requested a review from nbusseneau April 16, 2021 19:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 16, 2021
@nebril nebril added the release-note/ci This PR makes changes to the CI. label Apr 16, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 16, 2021
@nebril nebril force-pushed the pr/nebril/ensure-kubect-version branch from 293a2c0 to 32fc77d Compare April 16, 2021 19:16
@nebril
Copy link
Member Author

nebril commented Apr 16, 2021

test-me-please

This change makes K8s ginkgo test suite download kubectl version
compatible with current cluster version if it's not available.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/nebril/ensure-kubect-version branch from 32fc77d to 6438f0e Compare April 16, 2021 19:24
@nebril
Copy link
Member Author

nebril commented Apr 16, 2021

test-me-please

@joestringer
Copy link
Member

Also marked for 1.7 backport since we've seen similar CI failures against that branch.

@joestringer
Copy link
Member

Discussed on Slack, if this would fail then it would have failed already. We can follow up on whether to change the default path to something which is retained across node restart, but that's OK to do next week. Merging to unblock releases, will kick off backports of this PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants