Skip to content

Fix channel panic from ipcache kvstore reconnect #15668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2021
Merged

Fix channel panic from ipcache kvstore reconnect #15668

merged 1 commit into from
Apr 15, 2021

Conversation

jomenxiao
Copy link
Contributor

@jomenxiao jomenxiao commented Apr 13, 2021 •
edited
Loading

possible panic on closed channel with more than one time
fix #15667

Signed-off-by: Jomen Xiao jomenxiao@gmail.com

@jomenxiao jomenxiao requested a review from a team as a code owner April 13, 2021 05:57
@jomenxiao jomenxiao requested a review from jrajahalme April 13, 2021 05:57
@maintainer-s-little-helper
Copy link

Commit 71001cfdfa5c379791a8d6acdb1ffff373fb3a4e does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 13, 2021
aanm
aanm requested changes Apr 13, 2021
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nit.

@aanm aanm added needs-backport/1.7 release-note/bug This PR fixes an issue in a previous release of Cilium. labels Apr 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 13, 2021
@maintainer-s-little-helper
Copy link

Commits 71001cfdfa5c379791a8d6acdb1ffff373fb3a4e, 72326665e01f56f0f1268a46dd51de679f64054a do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link

Commits 71001cfdfa5c379791a8d6acdb1ffff373fb3a4e, 72326665e01f56f0f1268a46dd51de679f64054a, 252c0308284e26ddecf1ac404cd0e4be43bbaf8f do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link

Commits 71001cfdfa5c379791a8d6acdb1ffff373fb3a4e, 72326665e01f56f0f1268a46dd51de679f64054a, 252c0308284e26ddecf1ac404cd0e4be43bbaf8f, bd61394d20973f1b272d35d3d1d880da8f233353 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@jomenxiao
fix chan panic
ed23fe2 
Signed-off-by: jomenxiao <jomenxiao@gmail.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 14, 2021
aanm
aanm approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!.

@aanm
Copy link
Member

aanm commented Apr 14, 2021

test-me-please

1 similar comment
@aanm
Copy link
Member

aanm commented Apr 14, 2021

test-me-please

@aanm aanm merged commit 4a8f407 into cilium:master Apr 15, 2021
joestringer
joestringer reviewed Apr 15, 2021
View reviewed changes
@jrfastab jrfastab mentioned this pull request Apr 15, 2021
Merged
@jibi jibi mentioned this pull request Apr 19, 2021
Merged
@joestringer joestringer changed the title fix chan panic Fix channel panic from ipcache kvstore reconnect Apr 20, 2021
@joestringer joestringer mentioned this pull request Apr 20, 2021
Merged
@joamaki joamaki mentioned this pull request Apr 22, 2021
Merged
This was referenced Apr 28, 2021
Closed
Merged
@christarazi christarazi mentioned this pull request Apr 28, 2021
Merged
This was referenced May 13, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer left review comments

@aanm aanm aanm approved these changes

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees

@jrajahalme jrajahalme

Labels
release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix possible panic on closed channel
8 participants
@jomenxiao @aanm @joestringer @jibi @joamaki @ti-mo @christarazi @jrajahalme