Skip to content

backport v1.8: node-neigh: Query once netlink for neigh discovery device #15537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2021
Merged

backport v1.8: node-neigh: Query once netlink for neigh discovery device #15537

merged 1 commit into from
Apr 13, 2021

Conversation

brb
Copy link
Member

@brb brb commented Apr 1, 2021

Once this PR is merged, you can update the PR labels via:

$ for pr in 15431; do contrib/backporting/set-labels.py $pr done 1.8; done

@brb brb added kind/backports This PR provides functionality previously merged into master. backport/1.8 labels Apr 1, 2021
@brb brb requested a review from a team as a code owner April 1, 2021 11:17
@brb brb mentioned this pull request Apr 1, 2021
Merged
@brb brb force-pushed the pr/brb/v1.8-backport-neigh-query-once branch from feb0d1b to b24628c Compare April 7, 2021 12:27
@brb
Copy link
Member Author

brb commented Apr 7, 2021

test-backport-1.8

1 similar comment
@brb
Copy link
Member Author

brb commented Apr 7, 2021

test-backport-1.8

@brb brb force-pushed the pr/brb/v1.8-backport-neigh-query-once branch from b24628c to e7aedef Compare April 9, 2021 05:44
@brb
node-neigh: Query once netlink for neigh discovery device
e7aedef 
[ upstream commit 8f9a0bc ]

This commit calls netlink.LinkByName only once to retrieve a netdev used
for arpinging neighbors. We can optimize this, because the configuration
of cilium does not change during runtime.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
Copy link
Member Author

brb commented Apr 9, 2021

test-backport-1.8

@brb
Copy link
Member Author

brb commented Apr 9, 2021

The CI failures look unrelated. Running it again.

@brb
Copy link
Member Author

brb commented Apr 9, 2021

test-backport-1.8

2 similar comments
@brb
Copy link
Member Author

brb commented Apr 9, 2021

test-backport-1.8

@brb
Copy link
Member Author

brb commented Apr 12, 2021

test-backport-1.8

@errordeveloper
Copy link
Contributor

@brb can you include #15261 here?

@brb
Copy link
Member Author

brb commented Apr 12, 2021

test-backport-1.8

@brb
Copy link
Member Author

brb commented Apr 13, 2021

test-4.9

@brb
Copy link
Member Author

brb commented Apr 13, 2021

test-4.19

@errordeveloper errordeveloper mentioned this pull request Apr 13, 2021
Merged
@brb
Copy link
Member Author

brb commented Apr 13, 2021

CI 4.19 failures seems to be unrelated to my PR.

@aditighag
Copy link
Member

CI 4.19 failures seems to be unrelated to my PR.

@brb There are also 4.9 failures. Did you check those to see if they are also unrelated?

@aditighag
Copy link
Member

test-4.9

@brb
Copy link
Member Author

brb commented Apr 13, 2021

There are also 4.9 failures. Did you check those to see if they are also unrelated?

I am bit confused which ones of the 4.9 should pass. There are plenty of jobs 4.9 jobs which have passed.

@aditighag
Copy link
Member

aditighag commented Apr 13, 2021 •
edited
Loading

There are also 4.9 failures. Did you check those to see if they are also unrelated?

I am bit confused which ones of the 4.9 should pass. There are plenty of jobs 4.9 jobs which have passed.

Yeah, weird. 4.9 for k8s versions > 1.13 failed, except 1.18. 😕

@aditighag
Copy link
Member

Martynas suggested to merge this PR since the failures are unrelated.

@aditighag aditighag merged commit 44e138c into v1.8 Apr 13, 2021
@aditighag aditighag deleted the pr/brb/v1.8-backport-neigh-query-once branch April 13, 2021 20:39
@joestringer joestringer mentioned this pull request Apr 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brb @errordeveloper @aditighag