docs: Hide "Edit on GitHub" buttons #15579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the instructions here, remove the buttons to edit on github since this is confusing for contributors since it opens PRs against branches where we don't accept contributions, bypasses the standard instructions like requiring signoffs, etc. https://github.com/readthedocs/readthedocs.org/blob/master/docs/guides/remove-edit-buttons.rst Signed-off-by: Joe Stringer <joe@cilium.io>
|
I didn't test this yet, I just prepared a PR following the instructions in the link. I figured it's probably easiest to just submit & merge and get RTD to build the new version to validate. |
pchaigno
approved these changes
Apr 6, 2021
christarazi
approved these changes
Apr 6, 2021
|
Current documentation |
qmonnet
approved these changes
Apr 7, 2021
This was referenced Apr 7, 2021
aditighag
reviewed
Apr 7, 2021
This was referenced Apr 20, 2021
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the instructions here, remove the buttons to edit on github
since this is confusing for contributors since it opens PRs against
branches where we don't accept contributions, bypasses the standard
instructions like requiring signoffs, etc.
https://github.com/readthedocs/readthedocs.org/blob/master/docs/guides/remove-edit-buttons.rst