vendor: Bump vishvananda/netlink dependency #15408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test-backport-1.7 |
30df4b4 to
9ba51b9
Compare
joestringer
reviewed
Mar 20, 2021
joestringer
reviewed
Mar 20, 2021
Neighbor insertion can block indefinitely. See cilium#14710 for details. ``` goroutine 62 [syscall, 1080 minutes]: syscall.Syscall6(0x2d, 0x4e, 0xc002e27000, 0x1000, 0x0, 0xc004ba33e0, 0xc004ba33d4, 0x20, 0x21b1380, 0xc005241101) /usr/local/go/src/syscall/asm_linux_amd64.s:44 +0x5 syscall.recvfrom(0x4e, 0xc002e27000, 0x1000, 0x1000, 0x0, 0xc004ba33e0, 0xc004ba33d4, 0x27637a0, 0xc0015555c0, 0x0) /usr/local/go/src/syscall/zsyscall_linux_amd64.go:1618 +0xa3 syscall.Recvfrom(0x4e, 0xc002e27000, 0x1000, 0x1000, 0x0, 0x4, 0x0, 0x0, 0x0, 0x0) /usr/local/go/src/syscall/syscall_unix.go:273 +0xaf syscall.NetlinkRIB(0x12, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0) /usr/local/go/src/syscall/netlink_linux.go:71 +0x23c net.interfaceTable(0x0, 0x4, 0x4, 0x8, 0x18, 0xc002462cc0) /usr/local/go/src/net/interface_linux.go:17 +0x48 net.InterfaceByName(0xc0001dd298, 0x4, 0xc00a3e6a20, 0x10, 0x10) /usr/local/go/src/net/interface.go:157 +0x1a4 github.com/cilium/cilium/pkg/datapath/linux.(*linuxNodeHandler).insertNeighbor(0xc0008d4c30, 0xc004ba3b58, 0xc0001dd298, 0x4) /go/src/github.com/cilium/cilium/pkg/datapath/linux/node.go:591 +0x132 github.com/cilium/cilium/pkg/datapath/linux.(*linuxNodeHandler).nodeUpdate(0xc0008d4c30, 0x0, 0xc004ba3b58, 0x0, 0x0, 0x0) /go/src/github.com/cilium/cilium/pkg/datapath/linux/node.go:729 +0x18f github.com/cilium/cilium/pkg/datapath/linux.(*linuxNodeHandler).NodeValidateImplementation(0xc0008d4c30, 0xc0006a6ed0, 0x29, 0xc00a3e6958, 0x7, 0xc00be311d0, 0x2, 0x2, 0xc001646368, 0x0, ...) /go/src/github.com/cilium/cilium/pkg/datapath/linux/node.go:1171 +0x9b github.com/cilium/cilium/pkg/node/manager.(*Manager).backgroundSync.func1(0x27c8680, 0xc0008d4c30) /go/src/github.com/cilium/cilium/pkg/node/manager/manager.go:282 +0xaa github.com/cilium/cilium/pkg/node/manager.(*Manager).Iter(0xc00091c280, 0xc004ba3e08) /go/src/github.com/cilium/cilium/pkg/node/manager/manager.go:149 +0xe7 github.com/cilium/cilium/pkg/node/manager.(*Manager).backgroundSync(0xc00091c280) /go/src/github.com/cilium/cilium/pkg/node/manager/manager.go:281 +0x421 created by github.com/cilium/cilium/pkg/node/manager.NewManager /go/src/github.com/cilium/cilium/pkg/node/manager/manager.go:191 +0x673 ``` Signed-off-by: Thomas Graf <thomas@cilium.io>
joestringer
approved these changes
Mar 20, 2021
There was a problem hiding this comment.
I suspect we've been running these versions (or something very close) in the recent 1.8.8, 1.9.5 releases that we put out last week and we haven't heard much recently so I don't really anticipate any sort of regression from this. Not sure there's anything practical we can do to mitigate the potential risk here if the intent is to pull in fixes that are only available in much newer trees.
cfb2b53 to
3378798
Compare
Signed-off-by: Thomas Graf <thomas@cilium.io>
The netlink library depends on a more recent x/sys/unix Signed-off-by: Thomas Graf <thomas@cilium.io>
3378798 to
c232b81
Compare
|
test-backport-1.7 |
|
@tgraf @joestringer Unfortunately, this PR is not enough. We need to backport #15225 too. From the provided stack trace we can see that the Go's (Lots of issues, unnecessary work and confusion could have been avoided, if we agreed to backport #13112 to v1.{7,8,9}). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neighbor insertion can block indefinitely. See
#14710 for details.