Skip to content

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Mar 25, 2021

With ClusterMesh no longer requiring Cilium to run in etcd mode and CRD
being the default for many releases, there is no longer any value in
maintaining the complexity for managed etcd. Mark it for deprecation.

The guides for new cluster installation are removed immediately. The
helm options will remain until 1.11.

Fixes: #14205

@tgraf tgraf added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/major This PR introduces major new functionality to Cilium. labels Mar 25, 2021
@tgraf tgraf requested review from a team as code owners March 25, 2021 11:16
@tgraf tgraf requested review from a team, qmonnet, kaworu and nebril March 25, 2021 11:16
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs make -C install/kubernetes to update install/kubernetes/cilium/README.md, other than that LGTM.

@tgraf tgraf force-pushed the pr/tgraf/deprecate-etcd-operator branch from 73d9f88 to f7fb392 Compare March 25, 2021 11:22
@tgraf tgraf force-pushed the pr/tgraf/deprecate-etcd-operator branch from f7fb392 to 2f21036 Compare March 25, 2021 12:21
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation/gettingstarted/k8s-install-managed.rst needs to be updated too, the GH action complains about a broken reference in that file.

With ClusterMesh no longer requiring Cilium to run in etcd mode and CRD
being the default for many releases, there is no longer any value in
maintaining the complexity for managed etcd. Mark it for deprecation.

The guides for new cluster installation are removed immediately. The
helm options will remain until 1.11.

Fixes: cilium#14205

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf force-pushed the pr/tgraf/deprecate-etcd-operator branch from 2f21036 to 78318bd Compare March 25, 2021 12:30
@tgraf tgraf requested a review from kaworu March 25, 2021 12:37
@tgraf tgraf added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 26, 2021
@tgraf tgraf merged commit 4382905 into cilium:master Mar 26, 2021
@tgraf tgraf deleted the pr/tgraf/deprecate-etcd-operator branch March 26, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/major This PR introduces major new functionality to Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark Cilium etcd operator as deprecated
5 participants