docs: adds a rancher kubernetes engine installation guide #15323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
reviewed
Mar 12, 2021
qmonnet
reviewed
Mar 12, 2021
41639aa to
a4a48fb
Compare
joestringer
requested changes
Mar 12, 2021
There was a problem hiding this comment.
Looks like the feedback was all pretty straightforward and should be able to be addressed without too much effort. Would you mind fixing it up before we merge? Otherwise we tend to end up just ignoring any feedback and never following up.
(Maybe you intended to push an updated version but pushed the old version instead? I see the commit update in the page above but the changes don't appear to be present in the PR.)
Signed-off-by: Sean Winn <sean@isovalent.com>
a4a48fb to
ae68c89
Compare
|
@joestringer I simply missed adding the file, re-pushed |
joestringer
approved these changes
Mar 13, 2021
qmonnet
approved these changes
Mar 14, 2021
This was referenced Apr 20, 2021
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean Winn sean@isovalent.com
Adds a getting started guide for Rancher Kubernetes Engine
Fixes: #11380