bugtool: dump iptables-legacy and iptables-nft #15363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03f85ed to
3e4c119
Compare
pchaigno
reviewed
Mar 17, 2021
There was a problem hiding this comment.
One potential concern here is the size of the dump since we'll have iptables, iptables-legacy, and iptables-nft so there will be some duplicate files. I don't think that's a big concern given the bugtool report is most often compressed. It may also be a bit annoying to have to check which iptables is used to decide if we should look at iptables-legacy or iptables-nft.
3e4c119 to
c1486fa
Compare
pchaigno
reviewed
Mar 17, 2021
Fixes : cilium#15270 Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
c1486fa to
9d12464
Compare
pchaigno
approved these changes
Mar 17, 2021
|
Marked this PR as a candidate for backports given that this is an improvement for a debug tool, see https://docs.cilium.io/en/latest/contributing/release/backports/#backport-criteria. |
This was referenced Mar 19, 2021
This was referenced Apr 20, 2021
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #15270
Bugtool now dumps iptables-legacy and iptables-nft .
Signed-off-by: Gaurav Genani h3llix.pvt@gmail.com