backport v1.9: Fix possible deadlock when querying netdevs #15227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test-backport-1.9 Edit: hit variant of #14996 |
|
test-upstream-k8s |
|
retest-1.17-4.9 |
The bumped version includes the change [1] which sets a timeout for a default netlink socket. This prevents deadlocks when receiving a netlink msg (netlink is not reliable proto). [1]: vishvananda/netlink#614 Signed-off-by: Martynas Pumputis <m@lambda.lt>
This commit bumps github.com/cilium/arping version to accept netlink.Link instead of net.Interface. The change allows us to use netlink to query netdevs which avoids a possible deadlock described in the previous commit. Signed-off-by: Martynas Pumputis <m@lambda.lt>
a65fac9 to
57a80fd
Compare
|
test-backport-1.9 |
|
retest-gke |
aanm
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msgs.