backport v1.8: Fix possible deadlock when querying netdevs #15225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test-backport-1.8 |
|
Runtime provisioning failure: Upstream also failed to provision, although the Jenkins infrastructure did not identify that as the root cause: Travis hit a pull ratelimit from Docker: |
|
test-runtime |
|
test-upstream-k8s |
joestringer
approved these changes
Mar 6, 2021
9256fa1 to
cd56b0c
Compare
|
@joestringer Yep, I've dropped my netlink lib vsn bump, as the forked vsn (cilium/netlink) already contains the required change. |
This commit bumps github.com/cilium/arping version to accept netlink.Link instead of net.Interface. The change allows us to use netlink to query netdevs which avoids a possible deadlock described in the previous commit. Signed-off-by: Martynas Pumputis <m@lambda.lt>
cd56b0c to
49f65da
Compare
|
test-backport-1.8 |
This was referenced Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msg.