Improve release scripts #15294
Merged
Improve release scripts #15294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolinh
approved these changes
Mar 10, 2021
aanm
reviewed
Mar 10, 2021
|
Synced with andre offline, there was a couple of mixups here - URL should be fine and we can use the VERSION/ERSION trick to resolve the |
2c7bebd to
d37bb7b
Compare
|
@aanm I've pulled in a bunch of other enhancements from observations during the recent releases. |
It was previously ambiguous which repo needs to be up to date. Cilium/cilium must pull in the latest version of the branch after the merge in the previous step to ensure that we generate cilium/charts commits with the correct git shas from the cilium/cilium repository. Signed-off-by: Joe Stringer <joe@cilium.io>
This script previously assumed that you first checkout the branch where you will make the release, then run the script. By first pulling & creating the branch in the script, we can detect the "old_version" correctly with fewer dependencies on the release manager's environment. Reported-by: Chris Tarazi <chris@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
Rearrange the parameters and make version / github username optional parameters with some sane autodetection. Signed-off-by: Joe Stringer <joe@cilium.io>
962d8de to
e096918
Compare
aanm
approved these changes
Mar 29, 2021
This was referenced Mar 31, 2021
This was referenced Apr 20, 2021
This was referenced Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.