Skip to content

Conversation

l1b0k
Copy link
Contributor

@l1b0k l1b0k commented Mar 2, 2021

Hi, maintainers , this pr provide an AlibabaCloud Operator.
This allow Cilium deployments running in the AlibabaCloud and performs IP allocation based on IPs of ENI.

@l1b0k l1b0k requested a review from a team March 2, 2021 05:07
@l1b0k l1b0k requested a review from a team as a code owner March 2, 2021 05:07
@l1b0k l1b0k requested a review from a team March 2, 2021 05:07
@l1b0k l1b0k requested review from a team as code owners March 2, 2021 05:07
@l1b0k l1b0k requested review from a team March 2, 2021 05:07
@l1b0k l1b0k requested a review from a team as a code owner March 2, 2021 05:07
@l1b0k l1b0k requested a review from a team March 2, 2021 05:07
@l1b0k l1b0k requested review from a team as code owners March 2, 2021 05:07
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 2, 2021
@l1b0k l1b0k requested review from jibi, nathanjsweet and kkourt March 2, 2021 05:07
@l1b0k l1b0k requested a review from qmonnet March 2, 2021 05:07
@l1b0k l1b0k requested a review from gandro March 2, 2021 05:07
@l1b0k l1b0k requested a review from nebril March 2, 2021 05:07
@l1b0k l1b0k requested a review from tklauser March 2, 2021 05:07
@aanm aanm added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Mar 2, 2021
@qmonnet
Copy link
Member

qmonnet commented Apr 5, 2021

test-me-please

The AlibabaCloud allocator is specific to Cilium deployments running in the AlibabaCloud and performs IP allocation based on IPs of ENI.

More for ENI https://www.alibabacloud.com/help/doc-detail/58496.htm

Signed-off-by: l1b0k <libokang.dev@gmail.com>
@qmonnet
Copy link
Member

qmonnet commented Apr 5, 2021

test-me-please

@aanm aanm removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Apr 5, 2021
@aanm
Copy link
Member

aanm commented Apr 5, 2021

closing and re-opening for travis to kick in

@aanm aanm closed this Apr 5, 2021
@aanm aanm reopened this Apr 5, 2021
@aanm
Copy link
Member

aanm commented Apr 5, 2021

Travis is not collaborating... If it breaks on master we can always revert.

Thank you for this contribution @l1b0k! 🎉

@aanm aanm merged commit ae23400 into cilium:master Apr 5, 2021
@l1b0k l1b0k deleted the alibaba branch April 6, 2021 01:47
joamaki added a commit to joamaki/cilium that referenced this pull request Jun 10, 2021
Fix regression affecting IPAM CRD mode introduced in cilium#15160.

In buildAllocationResult an "ENI" error was wrongly constructed
in fallthrough case affecting all modes not specifically handled
within the switch statement.

Fixes: cilium#16492
Signed-off-by: Jussi Maki <jussi@isovalent.com>
aditighag pushed a commit that referenced this pull request Jun 10, 2021
Fix regression affecting IPAM CRD mode introduced in #15160.

In buildAllocationResult an "ENI" error was wrongly constructed
in fallthrough case affecting all modes not specifically handled
within the switch statement.

Fixes: #16492
Signed-off-by: Jussi Maki <jussi@isovalent.com>
gandro pushed a commit to gandro/cilium that referenced this pull request Jun 15, 2021
[ upstream commit 4118b04 ]

Fix regression affecting IPAM CRD mode introduced in cilium#15160.

In buildAllocationResult an "ENI" error was wrongly constructed
in fallthrough case affecting all modes not specifically handled
within the switch statement.

Fixes: cilium#16492
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
aanm pushed a commit that referenced this pull request Jun 16, 2021
[ upstream commit 4118b04 ]

Fix regression affecting IPAM CRD mode introduced in #15160.

In buildAllocationResult an "ENI" error was wrongly constructed
in fallthrough case affecting all modes not specifically handled
within the switch statement.

Fixes: #16492
Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/major This PR introduces major new functionality to Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.