refactor: Remove time.After from any Loops
#14380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7aa2fd5 to
8734c83
Compare
6d02ddf to
f1cd386
Compare
|
test-me-please |
aanm
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
@nathanjsweet the tests are failing in this line
cilium/test/provision/compile.sh
Line 113 in 712db13
f1cd386 to
e061447
Compare
`time.After` is not garbage collected until after its channel fires once. In situations where it is called repeatedely this *can* lead to significant memory build up. Instead of creating a new timer object for every iteration, a single timer, with a hard-reset mechanism, is used in situations where `time.After` is being called repeatedely. See the following article for details: https://medium.com/@oboturov/golang-time-after-is-not-garbage-collected-4cbc94740082 pkg: Add inctimer The new inctimer package is useful for boiling down the monotonous taks of "hard" resetting the reused timer. In order to reuse a timer to solve the `time.After` garbage collection problem the timer must be stopped, have its channel cleared (or not, if it was already read), and then reset. Duplicating this code all over the cilium code base seems superfluous, a small package that mimics the more terse `time.After` method seems more desireable. Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
e061447 to
c626046
Compare
|
test-me-please |
|
looks like we hit some kind of GH outage, rerunning tests |
|
test-me-please |
nebril
approved these changes
Dec 18, 2020
tklauser
approved these changes
Dec 18, 2020
fristonio
approved these changes
Dec 21, 2020
|
retest-runtime |
|
retest-gke |
|
The previous runtime test failed with |
|
Marking for backport to v1.9 as this is an important change to have for stable releases. |
This was referenced Sep 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time.Afteris not garbage collected until afterits channel fires once. In situations where it is called
repeatedly this can lead to significant memory build-up.
Instead of creating a new timer object for every iteration,
a single timer, with a hard-reset mechanism, is used in
situations where
time.Afteris being called repeatedly.See the following article for details:
https://medium.com/@oboturov/golang-time-after-is-not-garbage-collected-4cbc94740082
pkg: Add inctimer
The new inctimer package is useful for boiling down the monotonous
task of "hard" resetting the reused timer. In order to reuse a timer
to solve the
time.Aftergarbage collection problem the timer mustbe stopped, have its channel cleared (or not, if it was already read),
and then reset. Duplicating this code all over the cilium code base
seems superfluous, a small package that mimics the more terse
time.Aftermethod seems more desirable.Signed-off-by: Nate Sweet nathanjsweet@pm.me
fixes: #14219