node: Misc neighbor related changes #14070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing logfields * Inline neighborLog and get rid of debug statement * Convert the code to be more idiomatic Signed-off-by: Martynas Pumputis <m@lambda.lt>
The unit test checks whether permanent arp entries for a remote node are properly handled, i.e. added upon node update and removed upon node removal. Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
retest-runtime |
|
test-me-please |
kaworu
approved these changes
Nov 19, 2020
This was referenced Nov 21, 2020
This was referenced Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msgs.
Fix #10341
Marked for backporting, because the fix for #12824, which is going to be backported, relies on the changes in this PR.