Cilium k8s proxy performance #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
292ba34 to
79f8a94
Compare
tgraf
approved these changes
Sep 23, 2016
tgraf
requested changes
Sep 23, 2016
| continue | ||
| } | ||
|
|
||
| if isSvcIPv4 { |
There was a problem hiding this comment.
You can have a single isSvcIPv4 branch and do the !d.conf.IPv4Enabled check from within
|
|
||
| if isSvcIPv4 { | ||
| isEPsIPv6 := false | ||
| for epIP := range se.IPs { |
There was a problem hiding this comment.
You can move this into a function and use it from both branches
There was a problem hiding this comment.
Sorry, that code changed in the last commit. But still applies and I've change it under areIPsConsistent function
79f8a94 to
cdd145d
Compare
tgraf
approved these changes
Sep 27, 2016
Acked-by: Thomas Graf <thomas@cilium.io> Signed-off-by: André Martins <andre@cilium.io>
Acked-by: Thomas Graf <thomas@cilium.io> Signed-off-by: André Martins <andre@cilium.io>
Acked-by: Thomas Graf <thomas@cilium.io> Signed-off-by: André Martins <andre@cilium.io>
Acked-by: Thomas Graf <thomas@cilium.io> Signed-off-by: André Martins <andre@cilium.io>
Modified the code so it only updates the services whenever they were changed and not everytime cilium receives an update. Acked-by: Thomas Graf <thomas@cilium.io> Signed-off-by: André Martins <andre@cilium.io>
cdd145d to
34be2f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.