Skip to content

Conversation

pchaigno
Copy link
Member

Because network namespace cookies are only available in v5.7+, on older kernels, all pods on a given node will be serviced by the same backend for a given service, for east-west traffic.

Fixes: #13177

Because network namespace cookies are only available in v5.7+, on older
kernels, all pods on a given node will be serviced by the same backend
for a given service, for east-west traffic.

Fixes: 864f2f9 ("docs: Update list of optional kernel requirements")
Reported-by: Martynas Pumputis <m@lambda.lt>
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.8 labels Sep 29, 2020
@pchaigno pchaigno requested a review from brb September 29, 2020 06:40
@pchaigno pchaigno requested a review from a team as a code owner September 29, 2020 06:40
@borkmann borkmann merged commit deffa27 into master Sep 29, 2020
@borkmann borkmann deleted the pr/pchaigno/clarify-session-affinity-feature-support branch September 29, 2020 07:33
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see how we've clarified anything in this PR. The commit description describes at least some more information, but the text only now casts doubt on the feature support. What does "Full support" mean?

@pchaigno
Copy link
Member Author

Ok, "clarify" wasn't the right word; it should have been "don't give the wrong impression that session affinity is inexistent on <5.7" 😄

The table doesn't leave a lot of space for long explanation and I don't want to paraphrase the Session affinity documentation anyway. I thought "full support" would be okay because it hints that the situation may be more complex than 0/1, and further details are just a click away.

@joestringer
Copy link
Member

Ah, I didn't recognize when reviewing that the link explains what "full support" means. I figured there would be a little * with a footnote to briefly describe or point to the relevant docs or something. But if the session affinity link clarifies the meaning then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants