helm: Remove default toleration on hubble-relay deployment #13237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the default toleration of the hubble-relay deployment which allowed it to be scheduled on any node. In contrast to cilium and cilium-operator, which are capable of running in the host network namespace, Hubble Relay does require pod connectivity to be functional. The existing catch-all toleration was intended to provide cluster-wide network visibility in cases where nodes are unavailable. However, the current toleration can cause Hubble Relay to be scheduled on these unhealthy nodes and prevent it from running correctly, even though untainted nodes would have been available. Single-node clusters (such as minikube) intended to run workloads will not have any tainted nodes and are thus are unaffected by this change. Users who who have taints on every node in their cluster will have to use the newly introduced `hubble-relay.tolerations` Helm value to introduce custom tolerations for Hubble Relay. Fixes: #13166 Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
|
Note: In contrast to what was discussed in #13166, I opted to remove the toleration from Relay by default. While we could define
|
|
test-me-please |
rolinh
approved these changes
Sep 21, 2020
christarazi
approved these changes
Sep 21, 2020
kaworu
approved these changes
Sep 22, 2020
qmonnet
approved these changes
Sep 22, 2020
|
@gandro Should this be backported to 1.8? |
It wouldn't hurt. Should be fairly straightforward to backport. Adding the label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the default toleration of the hubble-relay deployment which
allowed it to be scheduled on any node. In contrast to cilium and
cilium-operator, which are capable of running in the host network
namespace, Hubble Relay does require pod connectivity to be functional.
The existing catch-all toleration was intended to provide cluster-wide
network visibility in cases where nodes are unavailable. However, the
current toleration can cause Hubble Relay to be scheduled on these
unhealthy nodes and prevent it from running correctly, even though
untainted nodes would have been available.
Single-node clusters (such as minikube) intended to run workloads will
not have any tainted nodes and are thus are unaffected by this change.
Users who who have taints on every node in their cluster will have to
use the newly introduced
hubble-relay.tolerationsHelm value tointroduce custom tolerations for Hubble Relay.
Fixes: #13166