Skip to content

test/conformance: Disable pulling latest image in ipv6 test #13204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2020
Merged

test/conformance: Disable pulling latest image in ipv6 test #13204

merged 1 commit into from
Sep 17, 2020

Conversation

sayboras
Copy link
Member

This PR is to update pullPolicy to Never, so that kind will use existing
loaded docker images.

This seems to be a miss in previous commit.

Signed-off-by: Tam Mach sayboras@yahoo.com

test/conformance: Disable pulling latest image in ipv6 test

@sayboras
test(conformance): Disable pulling latest image in ipv6 test
2c38ae4 
This PR is to update pullPolicy to Never, so that kind will use existing
loaded docker images.

This seems to be a miss in previous commit.

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@sayboras sayboras requested a review from a team as a code owner September 17, 2020 12:00
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 17, 2020
@sayboras sayboras added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Sep 17, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 17, 2020
@sayboras sayboras mentioned this pull request Sep 17, 2020
Merged
tklauser
tklauser approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@sayboras
Copy link
Member Author

One line change in GA, full CI is not required.

@vadorovsky vadorovsky merged commit 228f77e into cilium:master Sep 17, 2020
@sayboras sayboras deleted the bugfix/smoketest-ipv6 branch September 17, 2020 12:18
@joestringer joestringer mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sayboras @tklauser @vadorovsky