[v1.8] k8s: Consider session affinity parameters when comparing Services #13286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 745a26b ] Previously, if the `sessionAffinity` or `sessionAffinityTimeoutSec` of a Service changed, cilium would ignore the change. This meant that even though cilium correctly handles `sessionAffinity`, changing the `sessionAffinity` of a service without any other changes did not cause cilium to change its handling. Add `sessionAffinity` and `sessionAffinityTimeoutSec` handling to the comparator for services, so that cilium will notice affinity changes. Signed-off-by: Adam Wolfe Gordon <awg@digitalocean.com>
borkmann
approved these changes
Sep 25, 2020
|
test-backport-1.8 |
pchaigno
approved these changes
Sep 25, 2020
|
test-missed-k8s |
|
retest-4.19 |
|
Hit #6728 flake: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-K8s/3534/testReport/junit/Suite-k8s-1/14/K8sHealthTest_checks_cilium_health_status_between_nodes/ Given it's a known flake, we can ignore to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a direct backport of #13271 to 1.8.
Fixes: #12489