Skip to content

docs: backport documentation additions #13187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2020
Merged

docs: backport documentation additions #13187

merged 1 commit into from
Sep 23, 2020

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Sep 16, 2020

Update backport documentation

@kkourt kkourt requested review from a team as code owners September 16, 2020 10:44
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 16, 2020
@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label Sep 16, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 16, 2020
@kkourt kkourt requested a review from joestringer September 16, 2020 10:45
pchaigno
pchaigno reviewed Sep 16, 2020
View reviewed changes
@kkourt kkourt force-pushed the pr/kkourt/backport-docs-update branch 2 times, most recently from 35d536d to 1330d26 Compare September 16, 2020 14:34
joestringer
joestringer requested changes Sep 16, 2020
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying the guide :-)

I have a few suggestions below.

@maintainer-s-little-helper
Copy link

Commit 2bdcea0fde7c4e04bf683dff2477d9b3d53d400f does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 16, 2020
@kkourt kkourt force-pushed the pr/kkourt/backport-docs-update branch from 2bdcea0 to 75af821 Compare September 16, 2020 18:54
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Sep 16, 2020
@kkourt
Copy link
Contributor Author

kkourt commented Sep 16, 2020

Added @joestringer's suggestions and squashed everything into a single commit.

@kkourt kkourt requested a review from pchaigno September 18, 2020 13:02
pchaigno
pchaigno approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits below. Should be good to merge afterward.

@kkourt @joestringer
docs: backport documentation additions
771b6e4 
Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
Co-authored-by: Joe Stringer <joe@cilium.io>
@kkourt kkourt force-pushed the pr/kkourt/backport-docs-update branch from 75af821 to 771b6e4 Compare September 23, 2020 12:54
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 23, 2020
@qmonnet
Copy link
Member

qmonnet commented Sep 23, 2020

Careful with your PR title, I thought you meant to backport some “documentation additions” :)

@qmonnet qmonnet merged commit 510566a into master Sep 23, 2020
@qmonnet qmonnet deleted the pr/kkourt/backport-docs-update branch September 23, 2020 13:14
@vadorovsky vadorovsky mentioned this pull request Sep 25, 2020
Merged
@joestringer joestringer mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kkourt @qmonnet @joestringer @pchaigno @aanm @vadorovsky