Skip to content

docs: Removing wrong options from azure IPAM documentation. #13095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

docs: Removing wrong options from azure IPAM documentation. #13095

merged 1 commit into from
Sep 11, 2020

Conversation

chowmean
Copy link
Contributor

@chowmean chowmean commented Sep 4, 2020 •
edited by fristonio
Loading

Signed-off-by: Gaurav Yadav gaurav.dev.iiitm@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #13084

docs: Removing wrong options from azure IPAM documentation.

@chowmean
Fixing Documentation Bug: Removing unwanted lines
eb0bb90 
Signed-off-by: Gaurav Yadav <gaurav.dev.iiitm@gmail.com>
@chowmean chowmean requested a review from a team as a code owner September 4, 2020 14:28
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 4, 2020
@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Sep 4, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 4, 2020
@chowmean
Copy link
Contributor Author

chowmean commented Sep 6, 2020

Hi, anything else I have to add or change here?

fristonio
fristonio approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🚀

@fristonio fristonio requested a review from tgraf September 7, 2020 09:21
kkourt
kkourt approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the removed lines refer to aws switches, this LGTM.

@aanm aanm merged commit ed00ac6 into cilium:master Sep 11, 2020
@kkourt kkourt mentioned this pull request Sep 16, 2020
Merged
@joestringer joestringer mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@fristonio fristonio fristonio approved these changes

@tgraf tgraf Awaiting requested review from tgraf

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing mistake in doc Documentation/concepts/networking/ipam/azure.rst
4 participants
@chowmean @kkourt @fristonio @aanm