Skip to content

docs: Fix up upgrade sample indentation #13058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

docs: Fix up upgrade sample indentation #13058

merged 1 commit into from
Sep 3, 2020

Conversation

joestringer
Copy link
Member

The indentation here was off, causing the subsequent section to also be
considered part of the quote block. Fix it up. While we're at it,
clarify that the agent.keepDeprecatedProbes option should be specified
in addition to any other Helm options from the user.

@joestringer
docs: Fix up upgrade sample indentation
718948a 
The indentation here was off, causing the subsequent section to also be
considered part of the quote block. Fix it up. While we're at it,
clarify that the `agent.keepDeprecatedProbes` option should be specified
in addition to any other Helm options from the user.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. needs-backport/1.8 labels Sep 3, 2020
@joestringer joestringer requested a review from a team as a code owner September 3, 2020 00:21
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Sep 3, 2020
@joestringer joestringer added release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Sep 3, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 3, 2020
@rolinh rolinh added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 3, 2020
@aanm aanm merged commit 9f322f0 into cilium:master Sep 3, 2020
@joestringer joestringer deleted the submit/upgrade-docs-fix branch September 3, 2020 15:01
@pchaigno pchaigno mentioned this pull request Sep 7, 2020
Merged
@joestringer joestringer mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

@fristonio fristonio fristonio approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joestringer @pchaigno @christarazi @aanm @fristonio @rolinh