Skip to content

Update kops installation documentation #12884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2020
Merged

Update kops installation documentation #12884

merged 1 commit into from
Sep 2, 2020

Conversation

olemarkus
Copy link

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Removes references to things like CoreOS and old etcd versions. Also added some further reading links for those who want to configure cilium on kops further.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 14, 2020
@olemarkus olemarkus marked this pull request as ready for review August 14, 2020 08:28
@olemarkus olemarkus requested a review from a team as a code owner August 14, 2020 08:28
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Aug 14, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 14, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 37.116% when pulling da06d0f17f5bdbc9cef6fa5b451766af2d2287c1 on olemarkus:kops-docs into df36783 on cilium:master.

joestringer
joestringer approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, simpler instructions are a good sign 👍

I didn't try this out myself, but I presume you've already done so.

Update kops installation documentation
8079764 
Removes references to things like CoreOS and old etcd versions.
Also added some further reading links for those who want to configure
cilium on kops further.

Signed-off-by: Ole Markus With <o.with@sportradar.com>
@aanm aanm merged commit 06dbc52 into cilium:master Sep 2, 2020
@christarazi christarazi mentioned this pull request Sep 3, 2020
Merged
@borkmann borkmann mentioned this pull request Sep 3, 2020
Merged
@joestringer joestringer mentioned this pull request Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@olemarkus @coveralls @joestringer @tklauser @borkmann @christarazi @aanm @qmonnet