connectivity-check: re-introduce port-to-b NodePort checks #12788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8a03d54 ("Extend connectivity-check for HTTP policy validation via CUE (#12599)") introduced the usage of the CUE language to make the management of the connectivity checks easier and more consistent. But two deployments, "pod-to-b-intra-node-nodeport" and "pod-to-b-multi-node-nodeport", have accidentally been left out of the process. This commit reintroduces them. Only the cue file was hand-edited, the changes in the yaml files where generated by running "make". Fixes: 8a03d54 ("Extend connectivity-check for HTTP policy validation via CUE (#12599)") Fixes: #12599 Signed-off-by: Quentin Monnet <quentin@isovalent.com>
|
test-me-please (I also successfully deployed the resulting connectivity-check.yaml on AWS EKS. Deployment |
joestringer
approved these changes
Aug 5, 2020
christarazi
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8a03d54 (#12599) introduced the usage of the CUE language to make the management of the connectivity checks easier and more consistent. But two deployments,
pod-to-b-intra-node-nodeportandpod-to-b-multi-node-nodeport, have accidentally been left out of the process.This PR reintroduces them. Only the cue file was hand-edited, the changes in the yaml files where generated by running
make.