Add Kubernetes compatibility documentation #12783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Martins <andre@cilium.io>
Signed-off-by: André Martins <andre@cilium.io>
fristonio
approved these changes
Aug 5, 2020
joestringer
requested changes
Aug 5, 2020
| +-------------------------------+----------------------------------------------+ | ||
| | Feature | Tracking Issue | | ||
| +===============================+==============================================+ | ||
| | ``ipBlock`` set with a pod IP | https://github.com/cilium/cilium/issues/9209 | |
There was a problem hiding this comment.
AFAIK this isn't actually specified in KNP standards.
There was a problem hiding this comment.
That's true, but it is also not specified anywhere that it can't be a pod IP. There are upstream k8s tests that were currently skipping because of this limitation.
cilium/test/kubernetes-test.sh
Lines 76 to 83 in d80e66f
There was a problem hiding this comment.
I guess it's fair. Probably worth adding a comment to the related issue though to explain that the same traffic can (and should) be allowed via endpointSelector/podSelector policy instead of ipBlock - ie show the mitigation in case someone clicks through to that issue.
christarazi
approved these changes
Aug 5, 2020
joestringer
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked for backport on all branches so that users are clarify about this on all Cilium versions. Ping me if the backport didn't apply correctly.