Skip to content

envoy: Require Node only on the first request of a stream #12522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2020
Merged

envoy: Require Node only on the first request of a stream #12522

merged 1 commit into from
Jul 15, 2020

Conversation

jrajahalme
Copy link
Member

xDS request's Node field has grown huge and Envoy optionally only
sends it in the first request. Use this option an adapt xDS stream
processing accordingly.

Signed-off-by: Jarno Rajahalme jarno@covalent.io

@jrajahalme
envoy: Require Node only on the first request of a stream
b1feb02 
xDS request's Node field has grown huge and Envoy optionally only
sends it in the first request. Use this option an adapt xDS stream
processing accordingly.

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added kind/enhancement This would improve or streamline existing functionality. area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Jul 14, 2020
@jrajahalme jrajahalme requested review from a team as code owners July 14, 2020 15:35
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 37.021% when pulling b1feb02 on pr/jrajahalme/envoy-trim-node-info into cecf5a7 on master.

@qmonnet
Copy link
Member

qmonnet commented Jul 15, 2020

test-me-please

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 15, 2020
@qmonnet qmonnet merged commit 89f654d into master Jul 15, 2020
@qmonnet qmonnet deleted the pr/jrajahalme/envoy-trim-node-info branch July 15, 2020 15:58
jrajahalme added a commit that referenced this pull request Aug 6, 2020
@jrajahalme
envoy: Avoid logger pointer data race
7f51916 
Do not update local logger pointer while it is used from another goroutine.

Fixes: #12522
Fixes: #12791
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme mentioned this pull request Aug 6, 2020
Merged
aanm pushed a commit that referenced this pull request Aug 6, 2020
@jrajahalme @aanm
envoy: Avoid logger pointer data race
7a12b9a 
Do not update local logger pointer while it is used from another goroutine.

Fixes: #12522
Fixes: #12791
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme mentioned this pull request Sep 30, 2020
Merged
@jrajahalme jrajahalme mentioned this pull request Sep 30, 2020
Merged
@jrajahalme jrajahalme mentioned this pull request Sep 30, 2020
Merged
This was referenced Sep 30, 2020
Merged
Merged
@joestringer joestringer added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Sep 30, 2020
@joestringer joestringer mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@aditighag aditighag aditighag approved these changes

Assignees
No one assigned
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jrajahalme @coveralls @qmonnet @nebril @aditighag @joestringer @christarazi