Skip to content

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Jul 17, 2020

This PR adds new Hubble Relay options to allow for configuring flows sorting options. While there, rename options to SortBuffer... as this is more descriptive than just Buffer....

rolinh added 3 commits July 17, 2020 12:34
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
This commit adds new options to the Hubble-Relay binary so that the
per-request sort buffer length and drain timeout can be configured.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added kind/enhancement This would improve or streamline existing functionality. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. area/hubble area/helm Impacts helm charts and user deployment experience labels Jul 17, 2020
@rolinh rolinh requested review from a team as code owners July 17, 2020 12:31
@rolinh rolinh requested review from a team July 17, 2020 12:31
@rolinh
Copy link
Member Author

rolinh commented Jul 17, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 37.022% when pulling afe5217 on pr/rolinh/hubble-relay-buffer-opts into 0d8dba7 on master.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 20, 2020
@qmonnet qmonnet merged commit 878049b into master Jul 20, 2020
@qmonnet qmonnet deleted the pr/rolinh/hubble-relay-buffer-opts branch July 20, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Impacts helm charts and user deployment experience kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants