vendor: update github.com/google/gops to v0.3.10 #12283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test-me-please |
rolinh
approved these changes
Jun 25, 2020
aanm
approved these changes
Jun 25, 2020
This pulls in additional fixes for working around #11455 and will also get rid of two transitive dependencies: github.com/kardianos/osext and github.com/shirou/w32 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
d9c7fe6 to
bb296d3
Compare
|
test-me-please |
|
retest-runtime (vm provisioning failure due to docker pull timeouts) |
aanm
approved these changes
Jun 25, 2020
|
The runtime test failed to be provisioned but going to merge this since #12287 will retest everything again |
|
any chance of the gops bump being backported to 1.7.x or 1.8.x? google/gops#97 is missing from gops 0.3.6 and is generating TONS of "use of a closed connection" noise in our logs. |
tklauser
added a commit
that referenced
this pull request
Sep 9, 2020
[ upstream commit bb296d3 ] Manual backport of #12283 due to update of cilium-runtime and cilium-builder images. This pulls in additional fixes for working around #11455 and will also get rid of two transitive dependencies: github.com/kardianos/osext and github.com/shirou/w32 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
aanm
pushed a commit
that referenced
this pull request
Sep 10, 2020
[ upstream commit bb296d3 ] Manual backport of #12283 due to update of cilium-runtime and cilium-builder images. This pulls in additional fixes for working around #11455 and will also get rid of two transitive dependencies: github.com/kardianos/osext and github.com/shirou/w32 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@jdef this PR was backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in additional fixes for working around #11455
and will also get rid of two transitive dependencies:
github.com/kardianos/osext and github.com/shirou/w32