Skip to content

nodeinit: Fix for restarting kubenet managed pods #11779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2020
Merged

nodeinit: Fix for restarting kubenet managed pods #11779

merged 1 commit into from
May 29, 2020

Conversation

dctrwatson
Copy link
Contributor

When using restartPods in GKE, it would fail to actually restart kubenet managed pods because bad arguments are being passed to docker.

/var/lib/cni/networks/kubenet/10.3.1.2 looks like:

c937c5a3d5c2282881a86246f772d1b6f6619024e8555c2c205598baf51460e7
eth0

Resulting in:

Restarting kubenet managed pods
Error: No such container: c937c5a3d5c2282881a86246f772d1b6f6619024e8555c2c205598baf51460e7
Error: No such container: eth0

@dctrwatson dctrwatson requested a review from a team as a code owner May 29, 2020 17:59
@dctrwatson dctrwatson requested a review from a team May 29, 2020 17:59
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

aanm
aanm approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aanm aanm added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels May 29, 2020
@dctrwatson
nodeinit: Fix for restarting kubenet managed pods
aa78f49 
Signed-off-by: John Watson <johnw@planetscale.com>
@dctrwatson
Copy link
Contributor Author

I squashed my commits.

Seems there's also a trailing \r that needs to be removed too.

@tgraf tgraf merged commit 5e5c626 into cilium:master May 29, 2020
@dctrwatson dctrwatson deleted the gke-restart-fix branch May 29, 2020 19:23
@coveralls
Copy link

coveralls commented May 29, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.008%) to 36.839% when pulling aa78f49 on planetscale:gke-restart-fix into 15be0ee on cilium:master.

@tklauser tklauser mentioned this pull request Jun 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dctrwatson @coveralls @tgraf @aanm @tklauser