-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[v1.5] Dockerfile: Bump cilium-runtime to latest image #11626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Stringer <joe@cilium.io>
test-me-please |
aanm
approved these changes
May 20, 2020
tklauser
approved these changes
May 20, 2020
never-tell-me-the-odds |
1 similar comment
never-tell-me-the-odds |
never-tell-me-the-odds |
michi-covalent
approved these changes
May 21, 2020
Looks like the initial attempt at resolving the certificate issue was ineffective: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/19684/execution/node/96/log/
|
The vagrant box we ship & use with Cilium 1.5 uses certs generated over one year ago. Given that we intend to sunset Cilium 1.5 soon, rather than regenerating the certs & box, and dealing with updating the box image and so on for this branch, instead here we just copy the registry.sh from the latest cilium/packer-ci-build repository as of today and call it directly during vagrant provisioning. Fixes: #11641 Signed-off-by: Joe Stringer <joe@cilium.io>
117071a
to
3dd5376
Compare
never-tell-me-the-odds |
Added one last hack:
this should be enough of a band-aid to keep this from failing. |
nebril
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/backports
This PR provides functionality previously merged into master.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the cilium-runtime image to bump all OS dependencies.