Skip to content

test: Fix waiting for PODs #11506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

test: Fix waiting for PODs #11506

merged 1 commit into from
May 13, 2020

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented May 12, 2020 •
edited
Loading

Commit e82c444 inadvertently skipped waiting for all the needed PODs, potentially causing the tests to flake.

Fixes: #11413
Fixes: #11457
Signed-off-by: Jarno Rajahalme jarno@covalent.io

@jrajahalme
test: Fix waiting for PODs
4aeb3cd 
Commit e82c444 inadvertently skipped waiting for all the needed PODs, causing the tests to flake.

Fixes: #11413
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added kind/bug/CI This is a bug in the testing code. area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels May 12, 2020
@jrajahalme jrajahalme requested a review from a team as a code owner May 12, 2020 20:29
@jrajahalme
Copy link
Member Author

test-me-please

@coveralls
Copy link

coveralls commented May 12, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 37.833% when pulling 4aeb3cd on pr/jrajahalme/test-services-wait-pods-fix into 8e86001 on master.

@jrajahalme jrajahalme force-pushed the pr/jrajahalme/test-services-wait-pods-fix branch from 3b015e8 to 4aeb3cd Compare May 12, 2020 23:12
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme jrajahalme merged commit cf76459 into master May 13, 2020
@jrajahalme jrajahalme deleted the pr/jrajahalme/test-services-wait-pods-fix branch May 13, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake kind/bug/CI This is a bug in the testing code. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Suite-k8s-1.11.K8sServicesTest Checks ClusterIP Connectivity Checks service accessing itself (hairpin flow): Exitcode 28
2 participants
@jrajahalme @coveralls