loader: Attach bpf_host to cilium_net from Golang #11598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
bb2a2a9 to
bf7ce2e
Compare
aanm
approved these changes
May 25, 2020
bf7ce2e to
c3a8d22
Compare
c3a8d22 to
d12a28e
Compare
joestringer
approved these changes
May 26, 2020
|
Privileged unit tests need fixing 😞 |
289f009 to
543c95d
Compare
Attach bpf_host to the second host device (i.e., cilium_net) from Golang, as part of the host endpoint's datapath loading, instead of doing it from init.sh. Doing so has the following benefits: - We compile one less time because we only need to patch the object file on the Go side. - It simplifies the weird dance around includes in bpf_host.c. - It moves more code out of init.sh. Signed-off-by: Paul Chaignon <paul@cilium.io>
543c95d to
e1ad5fe
Compare
|
I was initially planning to go the long road and add support for the full host endpoint compilation+loading in the unit tests, but I'd like to get this PR into v1.8. The compilation+loading is well covered in the e2e tests anyway. In a nutshell: the host endpoint is a bit peculiar because it compiles and attached one object file to the first device, then patches it to attach to subsequent devices. However, in the unit tests, we compile and load dummy object files (e.g., with |
|
retest-gke |
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attach
bpf_hostto the second host device (i.e.,cilium_net) from Golang, as part of the host endpoint's datapath loading, instead of doing it frominit.sh.Doing so has the following benefits:
on the Go side.
bpf_host.c.init.sh.