Skip to content

test: Wait for POD readiness before test steps #11413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

test: Wait for POD readiness before test steps #11413

merged 1 commit into from
May 8, 2020

Conversation

jrajahalme
Copy link
Member

Applying an L7 policy may make 'httpGet' readiness probes fail for the
duration the policy is in effect. Reduce test flakiness by waiting for
POD readiness before applying any policies in the individual test
steps.

Signed-off-by: Jarno Rajahalme jarno@covalent.io

@jrajahalme
test: Wait for POD readiness before test steps
fb5a2a3 
Applying an L7 policy may make 'httpGet' readiness probes fail for the
duration the policy is in effect. Reduce test flakiness by waiting for
POD readiness before applying any policies in the individual test
steps.

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels May 7, 2020
@jrajahalme jrajahalme requested a review from a team as a code owner May 7, 2020 19:04
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme
Copy link
Member Author

test-gke

@jrajahalme jrajahalme force-pushed the pr/jrajahalme/test-wait-for-pod-readiness-before-tests branch from 9a04389 to fb5a2a3 Compare May 7, 2020 19:14
@jrajahalme
Copy link
Member Author

test-me-please

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 42.64% when pulling fb5a2a3 on pr/jrajahalme/test-wait-for-pod-readiness-before-tests into 61c2b4d on master.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 8, 2020
@nebril nebril merged commit e82c444 into master May 8, 2020
@nebril nebril deleted the pr/jrajahalme/test-wait-for-pod-readiness-before-tests branch May 8, 2020 12:58
@errordeveloper
Copy link
Contributor

I was looking into these flakes last week also, will see how it behaves now.

@jrajahalme jrajahalme mentioned this pull request May 12, 2020
Merged
jrajahalme added a commit that referenced this pull request May 12, 2020
@jrajahalme
test: Fix waiting for PODs
4aeb3cd 
Commit e82c444 inadvertently skipped waiting for all the needed PODs, causing the tests to flake.

Fixes: #11413
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
jrajahalme added a commit that referenced this pull request May 13, 2020
@jrajahalme
test: Fix waiting for PODs
cf76459 
Commit e82c444 inadvertently skipped waiting for all the needed PODs, causing the tests to flake.

Fixes: #11413
Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@brb brb mentioned this pull request May 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@vadorovsky vadorovsky vadorovsky approved these changes

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrajahalme @coveralls @errordeveloper @nebril @vadorovsky