Skip to content

Properly tear down gops agent on shutdown #11471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

Properly tear down gops agent on shutdown #11471

merged 1 commit into from
May 13, 2020

Conversation

tklauser
Copy link
Member

In all executables including the gops agent, make sure the gops agent is
properly teared down on exit and all the temporary files in
$HOME/.config created by it are cleaned up on shutdown by calling
gops/agent.Close() at the appropriate place.

For #11455

@tklauser tklauser added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. needs-backport/1.6 labels May 11, 2020
@tklauser tklauser requested a review from a team May 11, 2020 14:01
@tklauser tklauser requested a review from a team as a code owner May 11, 2020 14:01
@tklauser tklauser requested review from a team May 11, 2020 14:01
@tklauser tklauser requested review from a team as code owners May 11, 2020 14:01
@maintainer-s-little-helper
Copy link

Commits d2c040f039b4eb7f9b6d847ac2aad2855c5a73ee, 5014c434d6dba6441e52cd41a3acadc20642c1ac do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 11, 2020
@tklauser tklauser force-pushed the pr/tklauser/gops-cleanup-on-shutdown branch from 5014c43 to fca9154 Compare May 11, 2020 14:01
@maintainer-s-little-helper
Copy link

Commits d2c040f039b4eb7f9b6d847ac2aad2855c5a73ee, 5014c434d6dba6441e52cd41a3acadc20642c1ac do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@tklauser tklauser removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label May 11, 2020
@tklauser
Copy link
Member Author

test-me-please

rolinh
rolinh reviewed May 11, 2020
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Just a comment about bumping the gops version.

@tklauser tklauser force-pushed the pr/tklauser/gops-cleanup-on-shutdown branch from fca9154 to 2c5c4c5 Compare May 11, 2020 14:59
@tklauser
Copy link
Member Author

tklauser commented May 11, 2020 •
edited
Loading

test-me-please

EDIT: hit #11457 in 4.19 tests https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Kernel/1354/

rolinh
rolinh approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for backporters: ignore the hubble-relay change (hubble-relay is 1.8+).

@coveralls
Copy link

coveralls commented May 11, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0003%) to 37.836% when pulling 669a4c6 on pr/tklauser/gops-cleanup-on-shutdown into 74cc967 on master.

@tklauser
Copy link
Member Author

retest-4.19

@tklauser
Copy link
Member Author

retest-runtime

@tklauser
Copy link
Member Author

retest-4.9

@tklauser
Copy link
Member Author

retest-net-next

1 similar comment
@tklauser
Copy link
Member Author

retest-net-next

@tklauser tklauser mentioned this pull request May 12, 2020
Closed
@tklauser
Properly tear down gops agent on shutdown
669a4c6 
In all executables including the gops agent, make sure the gops agent is
properly teared down on exit and all the temporary files in
$HOME/.config created by it are cleaned up on shutdown by calling
gops/agent.Close() at the appropriate place.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/gops-cleanup-on-shutdown branch from 2c5c4c5 to 669a4c6 Compare May 12, 2020 14:43
@tklauser
Copy link
Member Author

tklauser commented May 12, 2020 •
edited
Loading

test-me-please

EDIT: failed runtime-4.9 tests with what looks like #10838 https://jenkins.cilium.io/job/Cilium-PR-Runtime-4.9/72/

@tklauser tklauser mentioned this pull request May 12, 2020
Closed
@tklauser
Copy link
Member Author

retest-4.9

@tklauser
Copy link
Member Author

retest-runtime

1 similar comment
@tklauser
Copy link
Member Author

retest-runtime

@tklauser
Copy link
Member Author

retest-net-next

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 13, 2020
@aanm aanm merged commit 1047583 into master May 13, 2020
@aanm aanm deleted the pr/tklauser/gops-cleanup-on-shutdown branch May 13, 2020 08:00
@joestringer joestringer mentioned this pull request May 13, 2020
Merged
@joestringer joestringer mentioned this pull request Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolinh rolinh rolinh approved these changes

@aanm aanm aanm approved these changes

+1 more reviewer

@errordeveloper errordeveloper errordeveloper approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tklauser @coveralls @errordeveloper @rolinh @aanm @joestringer