k8s: Do not send DeleteService event upon DeleteEndpoints #11467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, DeleteEndpoints() invocation might have sent DeleteService event (handled by pkg/k8s/watcher), if a service didn't have any endpoint left. This led to a double removal of the service in pkg/service, as kube-apiserver sends a dedicated Service object removal update, which is handled by DeleteService() which sends DeleteService event. This triggered "service not found" warning msg. To fix this, send UpdateService event instead of DeleteService from deleteEndpoints(), which would trigger only update in svc backends. The removal of a service is handled by a separate event anyways. Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
test-me-please |
tgraf
approved these changes
May 11, 2020
aanm
requested changes
May 11, 2020
aanm
approved these changes
May 11, 2020
|
CI hit #10763. |
|
retest-net-next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
DeleteEndpoints()invocation might have sentDeleteServiceevent (handled by
pkg/k8s/watcher), if a service didn't have any endpointleft. This led to a double removal of the service in
pkg/service, askube-apiserver sends a dedicated Service object removal update, which
is handled by
DeleteService()which sendsDeleteServiceevent.This triggered
"service not found"warning msg.To fix this, send
UpdateServiceevent instead ofDeleteServicefromdeleteEndpoints(), which would trigger only update in svc backends.The removal of a service is handled by a separate event anyways.
Fix #11399