-
Notifications
You must be signed in to change notification settings - Fork 3.4k
v1.7 backport 2020-04-29 bpf #11239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.7 backport 2020-04-29 bpf #11239
Conversation
[ upstream commit f25d8b9 ] When Cilium is used in chaining mode with portmap, the hostPort is translated using iptables DNAT as inserted by the portmap plugin. When this happens all within a node, we can preserve the source identity for the reply traffic for correct visibility. The traffic will be allowed anyway based on the connection tracking state. To work with clang-7 and avoid the pattern where the ctx is read into a register and then incremented then finally a value assigned to it, r1 = %[ctx] r1 += 8 ... *(u32)(r1 +=8) = %[mark] We wrote the code block in asm which is not the same as master branch which was able to use C code due to use of clang-11. We attempted to update the branch to clang-10 but that created a separate set of issue that was causing more code churn than we wanted. Updates: #9784 Signed-off-by: Thomas Graf <thomas@cilium.io> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
test-me-please |
Precheck failure:
|
5771b83
to
4953e81
Compare
test-me-please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[ upstream commit 9499596 ] Requires the following tests to pass: ``` NAME READY STATUS RESTARTS AGE echo-a-5f555bbc8b-9cxv9 1/1 Running 0 41s echo-b-659766fb56-zw2wl 1/1 Running 0 41s echo-b-host-65d7db76d8-5wmhm 1/1 Running 0 41s host-to-b-multi-node-clusterip-c7557d4f8-gv6ws 1/1 Running 0 41s host-to-b-multi-node-headless-5dfcdf9b76-9hcqn 1/1 Running 0 41s pod-to-a-6cf58894b7-mqg67 1/1 Running 0 40s pod-to-a-allowed-cnp-5898f7d8c9-bdfxz 1/1 Running 0 41s pod-to-a-external-1111-5779fb7cb9-tgdlh 1/1 Running 0 39s pod-to-a-l3-denied-cnp-74b9566cc7-zjhhh 1/1 Running 0 41s pod-to-b-intra-node-77b485d996-xfv45 1/1 Running 0 40s pod-to-b-intra-node-hostport-6c55bf8459-vddt2 1/1 Running 0 40s pod-to-b-multi-node-clusterip-75f5c78f68-2lk8x 1/1 Running 0 40s pod-to-b-multi-node-headless-5df88f9bd4-f5jlt 1/1 Running 0 40s pod-to-b-multi-node-hostport-d7c8d659f-4xqpt 1/1 Running 0 39s pod-to-external-fqdn-allow-google-cnp-74466b4c6f-dxvlq 1/1 Running 0 39s ``` Signed-off-by: Thomas Graf <thomas@cilium.io> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
4953e81
to
01d2c33
Compare
never-tell-me-the-odds |
1 similar comment
never-tell-me-the-odds |
|
never-tell-me-the-odds |
it seems the tests failures are related with changes:
|
@tgraf any guesses on what we might be missing here. Did a quick scan of the git log and didn't see much that was promising in the ./bpf side. |
never-tell-me-the-odds |
Upstream k8s build timed out fetching box: |
test-upstream-k8s |
1 similar comment
test-upstream-k8s |
|
test-upstream-k8s |
PR #10926 is completely reworked and converted to asm to enable old clang-7 compiler. From #10928 we only apply last remaining test commit. Without the backport of 10926 we were failing previous backports PR #11109 so it was moved here.