Skip to content

bpf: really only enforce bind rejection when in hostns #11210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2020
Merged

bpf: really only enforce bind rejection when in hostns #11210

merged 1 commit into from
Apr 29, 2020

Conversation

borkmann
Copy link
Member

See commit msg.

@borkmann borkmann added pending-review area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Apr 29, 2020
@borkmann borkmann requested review from gandro, brb and a team April 29, 2020 00:20
@borkmann
Copy link
Member Author

test-me-please

@borkmann
bpf: really only enforce bind rejection when in hostns
63b1ea3 
Bail out right away when we're not in host netns and if not the
case only /then/ do the proper bind checks for potential rejection.

Fixes: d7bf451 ("bpf: fix init namespace handling in sock lb programs")
Reported-by: Rene Zbinden <rene.zbinden@postfinance.ch>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann force-pushed the pr/bpf-host-lb-bind-fix branch from 8cd35ee to 63b1ea3 Compare April 29, 2020 00:23
@borkmann
Copy link
Member Author

test-me-please

@coveralls
Copy link

coveralls commented Apr 29, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 44.665% when pulling 63b1ea3 on pr/bpf-host-lb-bind-fix into c0ef36f on master.

@pchaigno pchaigno mentioned this pull request Apr 29, 2020
Merged
brb
brb approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@borkmann borkmann merged commit 248d689 into master Apr 29, 2020
@borkmann borkmann deleted the pr/bpf-host-lb-bind-fix branch April 29, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@brb brb brb approved these changes

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
area/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@borkmann @coveralls @gandro @brb @pchaigno