Skip to content

k8s/watchers: do not consider pods with empty podIPs #11282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2020
Merged

k8s/watchers: do not consider pods with empty podIPs #11282

merged 1 commit into from
May 1, 2020

Conversation

aanm
Copy link
Member

@aanm aanm commented May 1, 2020

Fixes: 308b946 ("pkg/k8s: add missing support for multi-stack")
Signed-off-by: André Martins andre@cilium.io

@aanm
k8s/watchers: do not consider pods with empty podIPs
30af31a 
Fixes: 308b946 ("pkg/k8s: add missing support for multi-stack")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels May 1, 2020
@aanm aanm requested a review from a team May 1, 2020 10:59
@aanm aanm added needs-backport/1.7 release-note/misc This PR makes changes that have no direct user impact. and removed release-note/bug This PR fixes an issue in a previous release of Cilium. labels May 1, 2020
@aanm
Copy link
Member Author

aanm commented May 1, 2020

test-me-please

@aanm aanm marked this pull request as draft May 1, 2020 11:02
@aanm aanm marked this pull request as ready for review May 1, 2020 11:03
@aanm aanm removed the kind/bug This is a bug in the Cilium logic. label May 1, 2020
@aanm
Copy link
Member Author

aanm commented May 1, 2020

test-with-kernel

@maintainer-s-little-helper
Copy link

I could have merged this PR if @aanm would let me!

@aanm aanm added the kind/bug This is a bug in the Cilium logic. label May 1, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 1, 2020
@aanm aanm removed the kind/bug This is a bug in the Cilium logic. label May 1, 2020
@aanm aanm merged commit 988e504 into master May 1, 2020
@aanm aanm deleted the pr/error-empty-pod-ips branch May 1, 2020 15:06
@christarazi christarazi mentioned this pull request May 8, 2020
Merged
@aanm aanm mentioned this pull request May 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aanm @tgraf @gandro