Skip to content

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Apr 30, 2020

The operator-specific flags were not populated

Fixes: 588f835 ("operator: split operator-only options into separate package")

The operator specific flags were not populated

Fixes: 588f835 ("operator: split operator-only options into separate package")
Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf added kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact. labels Apr 30, 2020
@tgraf tgraf requested a review from tklauser April 30, 2020 21:26
@tgraf
Copy link
Member Author

tgraf commented Apr 30, 2020

test-me-please

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. Thanks for catching it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 44.624% when pulling adb78fb on pr/tgraf/fix-operator-flags into 462da1d on master.

@joestringer
Copy link
Member

joestringer commented Apr 30, 2020

Hit #11213, also #11127

@joestringer
Copy link
Member

Fix looks clear, CI flakes seem irrelevant. Good to merge.

@joestringer joestringer merged commit ba3a74b into master Apr 30, 2020
@joestringer joestringer deleted the pr/tgraf/fix-operator-flags branch April 30, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants