Skip to content

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 29, 2020

As multi-stack also means that pods can contain 2 or more IP addresses
we should also populate the local podIPs also with the ones provided by
kubernetes.

Fixes: 47a87f8 ("pkg/k8s: add support for multi-stack")
Signed-off-by: André Martins andre@cilium.io

@aanm aanm added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.7 labels Apr 29, 2020
@aanm aanm requested a review from a team April 29, 2020 21:22
@aanm aanm marked this pull request as draft April 29, 2020 21:23
@aanm
Copy link
Member Author

aanm commented Apr 29, 2020

test-me-please

@aanm aanm force-pushed the pr/fix-dual-stack-deployment branch from c771986 to 7747af7 Compare April 29, 2020 21:25
@aanm aanm marked this pull request as ready for review April 29, 2020 21:25
@aanm aanm requested a review from a team as a code owner April 29, 2020 21:25
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for hostport bits

@aanm aanm force-pushed the pr/fix-dual-stack-deployment branch from 7747af7 to 6a1273b Compare April 30, 2020 06:03
As multi-stack also means that pods can contain 2 or more IP addresses
we should also populate the local podIPs also with the ones provided by
kubernetes.

Fixes: 47a87f8 ("pkg/k8s: add support for multi-stack")
Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm force-pushed the pr/fix-dual-stack-deployment branch from 6a1273b to 1dbf3c9 Compare April 30, 2020 06:07
@aanm
Copy link
Member Author

aanm commented Apr 30, 2020

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 44.608% when pulling 1dbf3c9 on pr/fix-dual-stack-deployment into 97f8299 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants