Skip to content

Conversation

jrajahalme
Copy link
Member

Add detail to WriteMsgIP log messages in hopes to understand why we
sometimes see a lot of these logs.

Signed-off-by: Jarno Rajahalme jarno@covalent.io

@jrajahalme jrajahalme added kind/enhancement This would improve or streamline existing functionality. pending-review area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. release-note/misc This PR makes changes that have no direct user impact. labels Apr 17, 2020
@jrajahalme jrajahalme requested a review from a team April 17, 2020 15:32
@jrajahalme
Copy link
Member Author

test-me-please

@jrajahalme jrajahalme force-pushed the pr/jrajahalme/dnsproxy-add-udp-logging-detail branch 2 times, most recently from 20b1c7f to 7fc8b04 Compare April 17, 2020 16:59
@jrajahalme
Copy link
Member Author

test-me-please

@coveralls
Copy link

coveralls commented Apr 17, 2020

Coverage Status

Coverage decreased (-0.02%) to 44.75% when pulling 5db77d0 on pr/jrajahalme/dnsproxy-add-udp-logging-detail into 3c44ae5 on master.

@jrajahalme
Copy link
Member Author

Apparent CI timeout, K8s 1.11 was killed without any failures, testing again.

@jrajahalme
Copy link
Member Author

test-me-please

@aanm
Copy link
Member

aanm commented Apr 20, 2020

@jrajahalme needs rebase against master so the tests don't timeout

@pchaigno pchaigno added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Apr 21, 2020
Add detail to WriteMsgIP log messages in hopes to understand why we
sometimes see a lot of these logs.

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme force-pushed the pr/jrajahalme/dnsproxy-add-udp-logging-detail branch from 7fc8b04 to 5db77d0 Compare April 25, 2020 02:28
@jrajahalme
Copy link
Member Author

test-me-please

@aanm aanm removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Apr 27, 2020
@aanm aanm merged commit d07eec5 into master Apr 27, 2020
@aanm aanm deleted the pr/jrajahalme/dnsproxy-add-udp-logging-detail branch April 27, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants