Skip to content

Conversation

tklauser
Copy link
Member

The cilium-docker plugin needs access to the docker socket, thus a bind
mount is needed.

Fixes #10962

Fix Docker getting started guide example.

…compose.yml

The cilium-docker plugin needs access to the docker socket, thus a bind
mount is needed.

Fixes #10962

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added pending-review release-note/bug This PR fixes an issue in a previous release of Cilium. labels Apr 16, 2020
@tklauser tklauser requested a review from a team as a code owner April 16, 2020 20:42
@tklauser
Copy link
Member Author

test-me-please

@tklauser tklauser marked this pull request as draft April 16, 2020 21:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 46.773% when pulling 724b69c on pr/tklauser/docker-gsg-fix into 8b74e24 on master.

@tklauser tklauser marked this pull request as ready for review April 16, 2020 21:09
@tgraf tgraf merged commit 2d6e3be into master Apr 17, 2020
@tgraf tgraf deleted the pr/tklauser/docker-gsg-fix branch April 17, 2020 07:34
@jrfastab
Copy link
Contributor

This is reverted by a91847e dropping backports flag to avoid sending commit/revert through backports.

@tklauser
Copy link
Member Author

Note that a91847e is reverting #11022, not this PR (#11023). I think this PR still needs to be backported in order for the Docker GSG to work on v1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker getting-started guide is broken
7 participants