Skip to content

Conversation

danwent
Copy link
Contributor

@danwent danwent commented Apr 20, 2020

Signed-off-by: Dan Wendlandt dan@covalent.io

@danwent danwent requested a review from a team as a code owner April 20, 2020 15:29
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@coveralls
Copy link

coveralls commented Apr 20, 2020

Coverage Status

Coverage increased (+0.007%) to 44.672% when pulling 8934e2d on danwent:eks-overlay-note into 5c0b426 on cilium:master.

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor wording nit.

similar to the behavior of the
`Amazon VPC CNI plugin <https://docs.aws.amazon.com/eks/latest/userguide/pod-networking.html>`_.

Cilium can also run in EKS using an overlay mode that gives pods non-VPC-routable IPs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Cilium can also run in EKS using an overlay mode that gives pods non-VPC-routable IPs.
Cilium can alternatively run in EKS using an overlay mode that gives pods non-VPC-routable IPs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Just pushed this change.

Signed-off-by: Dan Wendlandt <dan@covalent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants