Skip to content

ci: adjust kernel jenkinsfile to be more versatile #11061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2020
Merged

ci: adjust kernel jenkinsfile to be more versatile #11061

merged 1 commit into from
May 4, 2020

Conversation

nebril
Copy link
Member

@nebril nebril commented Apr 20, 2020

This change will help use one jenkinsfile for all k8s-kernel versions
combinations.

@nebril nebril requested a review from a team as a code owner April 20, 2020 12:51
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@nebril
Copy link
Member Author

nebril commented Apr 20, 2020

test-test

@nebril
Copy link
Member Author

nebril commented Apr 20, 2020

test-test

@coveralls
Copy link

coveralls commented Apr 20, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 44.637% when pulling b3d6852 on pr/trial-prs into 43570d5 on master.

aanm
aanm reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@aanm aanm requested a review from a team April 23, 2020 12:40
@nebril nebril marked this pull request as draft April 23, 2020 13:00
@nebril
Copy link
Member Author

nebril commented Apr 23, 2020

test-test

2 similar comments
@nebril
Copy link
Member Author

nebril commented Apr 23, 2020

test-test

@nebril
Copy link
Member Author

nebril commented Apr 23, 2020

test-test

@ciliumbot
Copy link

Build finished.

@nebril
Copy link
Member Author

nebril commented Apr 23, 2020

test-test

@nebril
Copy link
Member Author

nebril commented Apr 23, 2020

test-with-kernel

@nebril
Copy link
Member Author

nebril commented Apr 23, 2020

test-test

1 similar comment
@nebril
Copy link
Member Author

nebril commented Apr 23, 2020

test-test

@nebril
Copy link
Member Author

nebril commented Apr 23, 2020

test-with-kernel

@nebril
Copy link
Member Author

nebril commented Apr 27, 2020

test-test

@nebril
Copy link
Member Author

nebril commented Apr 27, 2020

test-with-kernel

@nebril
Copy link
Member Author

nebril commented Apr 27, 2020

test-test

@nebril
Copy link
Member Author

nebril commented Apr 27, 2020

test-with-kernel

@nebril nebril added the release-note/ci This PR makes changes to the CI. label Apr 28, 2020
@nebril
Copy link
Member Author

nebril commented Apr 28, 2020

test-test

@nebril
Copy link
Member Author

nebril commented Apr 28, 2020

test-with-kernel

@nebril
Copy link
Member Author

nebril commented Apr 28, 2020

test-test

@nebril
Copy link
Member Author

nebril commented Apr 28, 2020

test-with-kernel

@nebril
Copy link
Member Author

nebril commented Apr 28, 2020

retest-ginkgo

@nebril
Copy link
Member Author

nebril commented Apr 28, 2020

restart-ginkgo

@nebril nebril marked this pull request as ready for review April 28, 2020 17:04
@nebril nebril requested a review from a team as a code owner April 28, 2020 17:04
raybejjani
raybejjani approved these changes Apr 28, 2020
View reviewed changes
@raybejjani raybejjani mentioned this pull request Apr 28, 2020
Merged
aanm
aanm requested changes Apr 29, 2020
View reviewed changes
@nebril
ci: adjust kernel jenkinsfile to be more versatile
5fe7811 
This change will help use one jenkinsfile for all k8s-kernel versions
combinations.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@aanm aanm merged commit 4bdb361 into master May 4, 2020
@aanm aanm deleted the pr/trial-prs branch May 4, 2020 16:30
qmonnet added a commit to qmonnet/cilium that referenced this pull request Mar 19, 2021
@qmonnet
test: make RunsOnNetNextKernel() helper work with KERNEL="net-next"
eb92f1a 
The NETNEXT environment variable, set to "1" or to "true", has
traditionally instructed the CI to use the net-next kernel for the
Vagrant virtual machines. For some time, the KERNEL variable has also
been assuming this role, if its value is set to "net-next" (see
test/Vagrantfile). But the relevant helper in the CI is not aware of
that, and when passing KERNEL="net-next" instead of NETNEXT="true",
ginkgo will skip tests that should run on the net-next kernel.

Let's update the relevant helper to fix this issue.

Fixes: cilium#11061

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
@qmonnet qmonnet mentioned this pull request Mar 19, 2021
Merged
brb pushed a commit that referenced this pull request Mar 24, 2021
@qmonnet @brb
test: make RunsOnNetNextKernel() helper work with KERNEL="net-next"
b6dc814 
The NETNEXT environment variable, set to "1" or to "true", has
traditionally instructed the CI to use the net-next kernel for the
Vagrant virtual machines. For some time, the KERNEL variable has also
been assuming this role, if its value is set to "net-next" (see
test/Vagrantfile). But the relevant helper in the CI is not aware of
that, and when passing KERNEL="net-next" instead of NETNEXT="true",
ginkgo will skip tests that should run on the net-next kernel.

Let's update the relevant helper to fix this issue.

Fixes: #11061

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
aanm pushed a commit to aanm/cilium that referenced this pull request Mar 31, 2021
@qmonnet @aanm
test: make RunsOnNetNextKernel() helper work with KERNEL="net-next"
d61784b 
[ upstream commit b6dc814 ]

The NETNEXT environment variable, set to "1" or to "true", has
traditionally instructed the CI to use the net-next kernel for the
Vagrant virtual machines. For some time, the KERNEL variable has also
been assuming this role, if its value is set to "net-next" (see
test/Vagrantfile). But the relevant helper in the CI is not aware of
that, and when passing KERNEL="net-next" instead of NETNEXT="true",
ginkgo will skip tests that should run on the net-next kernel.

Let's update the relevant helper to fix this issue.

Fixes: cilium#11061

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
aanm pushed a commit to aanm/cilium that referenced this pull request Apr 1, 2021
@qmonnet @aanm
test: make RunsOnNetNextKernel() helper work with KERNEL="net-next"
87ab3fb 
[ upstream commit b6dc814 ]

The NETNEXT environment variable, set to "1" or to "true", has
traditionally instructed the CI to use the net-next kernel for the
Vagrant virtual machines. For some time, the KERNEL variable has also
been assuming this role, if its value is set to "net-next" (see
test/Vagrantfile). But the relevant helper in the CI is not aware of
that, and when passing KERNEL="net-next" instead of NETNEXT="true",
ginkgo will skip tests that should run on the net-next kernel.

Let's update the relevant helper to fix this issue.

Fixes: cilium#11061

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
aanm pushed a commit that referenced this pull request Apr 1, 2021
@qmonnet @aanm
test: make RunsOnNetNextKernel() helper work with KERNEL="net-next"
ce1fbf2 
[ upstream commit b6dc814 ]

The NETNEXT environment variable, set to "1" or to "true", has
traditionally instructed the CI to use the net-next kernel for the
Vagrant virtual machines. For some time, the KERNEL variable has also
been assuming this role, if its value is set to "net-next" (see
test/Vagrantfile). But the relevant helper in the CI is not aware of
that, and when passing KERNEL="net-next" instead of NETNEXT="true",
ginkgo will skip tests that should run on the net-next kernel.

Let's update the relevant helper to fix this issue.

Fixes: #11061

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
aanm pushed a commit that referenced this pull request Apr 1, 2021
@qmonnet @aanm
test: make RunsOnNetNextKernel() helper work with KERNEL="net-next"
95bf359 
[ upstream commit b6dc814 ]

The NETNEXT environment variable, set to "1" or to "true", has
traditionally instructed the CI to use the net-next kernel for the
Vagrant virtual machines. For some time, the KERNEL variable has also
been assuming this role, if its value is set to "net-next" (see
test/Vagrantfile). But the relevant helper in the CI is not aware of
that, and when passing KERNEL="net-next" instead of NETNEXT="true",
ginkgo will skip tests that should run on the net-next kernel.

Let's update the relevant helper to fix this issue.

Fixes: #11061

Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

+1 more reviewer

@raybejjani raybejjani raybejjani approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nebril @coveralls @ciliumbot @raybejjani @aanm