Restore node IP behavior of Cilium < 1.7 #11057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6933a66 to
1167f64
Compare
aanm
requested changes
Apr 20, 2020
1167f64 to
94183a4
Compare
|
test-me-please |
joestringer
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
I pondered for a bit whether users who unintentionally picked up this behaviour in v1.7.2 (and populated local ipcaches) would require any additional manual intervention to ensure that the entries are cleaned up during upgrade. My conclusion was that this is not necessary since we will recreate the ipcache map during startup, and the new logic will kick in at that point. 👍
Minor nit below.
94183a4 to
5a0be55
Compare
|
test-me-please |
Commit bbfabcf added all IPs of a node to the ipcache to unify the behavior of the identity representing a node. While the fix is correct, it results in unexpected behavior change for some users. Revert the behavior and only do so if remote-node identities are enabled which is the new opt-in behavior starting with Cilium 1.7. Fixes: bbfabcf ("node: Assign remote node identity to all node IPs") Signed-off-by: Thomas Graf <thomas@cilium.io>
…added Even though some IPs have been excluded from being added to the ipcache. The same IPs have not been excluded when deleting thus resulting in an attempt to remove IPs in the ipcache which clearly were not owned by the node resource. Signed-off-by: Thomas Graf <thomas@cilium.io>
The IPs were added but never deleted Signed-off-by: Thomas Graf <thomas@cilium.io>
5a0be55 to
bc33662
Compare
|
test-me-please |
aanm
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the exact node IP behavior unless remote-node identities are enabled. It also fixes two bugs in separate commits that have been discovered by the unit tests added as part of this work.