helm: add option to enable automatic etcd name resolution #10918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is useful if users want to deploy an k8s service that translates to an etcd cluster. As already implemented in Cilium, it will perform the service translation internally without having to reach a DNS to perform this translation. This will work by relying on the watching mechanism that we have for k8s for which it is required that `disabled-k8s-services` is set to `false` Signed-off-by: André Martins <andre@cilium.io>
278e340 to
1e31276
Compare
|
test-me-please |
tklauser
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is useful if users want to deploy an k8s service
that translates to an etcd cluster. As already implemented in Cilium, it
will perform the service translation internally without having to reach
a DNS to perform this translation. This will work by relying on the
watching mechanism that we have for k8s for which it is required that
disabled-k8s-servicesis set tofalseSigned-off-by: André Martins andre@cilium.io