Skip to content

Docs policy title rename #10854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

Docs policy title rename #10854

merged 1 commit into from
Apr 9, 2020

Conversation

danwent
Copy link
Contributor

@danwent danwent commented Apr 5, 2020 •
edited
Loading

We do not have a separate policy tutorial that covers basic identity-aware network policy, but the title of the star wars demo just talks about HTTP, despite the fact that it covers both label-based identity policies as well as HTTP-aware policies. Just make the title reflect this.

@danwent danwent requested a review from a team as a code owner April 5, 2020 03:28
@maintainer-s-little-helper
Copy link

Please set the appropriate release note label.

@coveralls
Copy link

coveralls commented Apr 5, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 46.962% when pulling 64b7fbf on danwent:docs-policy-rename into 418500b on cilium:master.

qmonnet
qmonnet reviewed Apr 6, 2020
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit on title change looks good, but it looks like the other commit was added to this PR by mistake? I think this is the commit already submitted in #10853.

@qmonnet qmonnet added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Apr 6, 2020
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Apr 6, 2020
soumynathan
soumynathan reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@soumynathan soumynathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danwent
docs: Change titles of star wars network policy tutorial
64b7fbf 
Signed-off-by: Dan Wendlandt <dan@covalent.io>
@danwent danwent force-pushed the docs-policy-rename branch from d8f4f62 to 64b7fbf Compare April 8, 2020 13:51
@danwent
Copy link
Contributor Author

danwent commented Apr 8, 2020

@qmonnet , ah good catch. Sorry about that! I've cleaned up and re-pushed.

@aanm aanm merged commit 3fe0838 into cilium:master Apr 9, 2020
@christarazi christarazi mentioned this pull request May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet left review comments

+1 more reviewer

@soumynathan soumynathan soumynathan left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danwent @coveralls @soumynathan @qmonnet @joestringer @christarazi @aanm